Skip to content

test: guard against overlapping fixer ownership#206

Merged
zeitlinger merged 1 commit intomainfrom
fix/disallow-overlapping-fixers
Apr 22, 2026
Merged

test: guard against overlapping fixer ownership#206
zeitlinger merged 1 commit intomainfrom
fix/disallow-overlapping-fixers

Conversation

@zeitlinger
Copy link
Copy Markdown
Member

Summary

  • add a registry invariant test for overlapping fixer ownership
  • allow only a small explicit set of intentional overlaps
  • fail fast when a new competing fixer claims an already-owned pattern

Testing

  • cargo test competing_fixers_must_not_share_declared_patterns
  • cargo test readme_linter_table_in_sync
  • cargo test all_flint_repo_linters_detected

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Copilot AI review requested due to automatic review settings April 22, 2026 05:11
@zeitlinger zeitlinger requested a review from a team as a code owner April 22, 2026 05:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a registry invariant test to prevent two different fixer tools from declaring ownership of the same file pattern, with an explicit allowlist for a small set of intentional overlaps.

Changes:

  • Added competing_fixers_must_not_share_declared_patterns registry invariant test.
  • Introduced an explicit allowlist for known intentional overlaps (e.g., markdownlint vs prettier; clippy vs fmt).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/registry/tests.rs
@zeitlinger zeitlinger enabled auto-merge (squash) April 22, 2026 05:16
@zeitlinger zeitlinger merged commit f71229d into main Apr 22, 2026
18 checks passed
@zeitlinger zeitlinger deleted the fix/disallow-overlapping-fixers branch April 22, 2026 16:19
@github-actions github-actions Bot mentioned this pull request Apr 22, 2026
zeitlinger pushed a commit that referenced this pull request Apr 23, 2026
### Added

- group linter renovate updates
([#209](#209))

### Fixed

- expand baseline guards for config and flint changes
([#215](#215))
- remove stale exclude_paths init placeholder
([#211](#211))
- baseline lint coverage changes
([#214](#214))
- align biome init and formatter ownership
([#205](#205))

### Other

- *(deps)* update dependency npm:renovate to v43.133.0
([#216](#216))
- *(deps)* update dependency npm:renovate to v43.132.2
([#212](#212))
- *(deps)* update taiki-e/install-action digest to 5f57d6c
([#204](#204))
- clarify that flint init works with existing mise.toml
([#208](#208))
- guard against overlapping fixer ownership
([#206](#206))

> [!IMPORTANT]
> Close and reopen this PR to trigger CI checks.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants