fix: align biome init and formatter ownership#205
Merged
zeitlinger merged 3 commits intomainfrom Apr 23, 2026
Merged
Conversation
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts formatter “ownership” so Biome and Prettier don’t both try to format the same files, while also ensuring flint init generates a Biome config that matches the repo’s space-indentation style.
Changes:
- Generate a
biome.jsonwith explicit 2-space indentation duringflint initwhen Biome is selected and no Biome config exists. - Remove Prettier’s project-wide
--fullcommand so full-mode remains scoped to its declared*.md/*.yml/*.yamlpatterns. - Add an e2e regression test covering the Prettier-vs-Biome formatter ownership conflict on
biome.jsonc.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tests/e2e.rs |
Adds an e2e regression ensuring --full Prettier doesn’t target Biome-owned JSONC and that fix exits non-zero on disagreement. |
tests/cases/general/init-rust/test.toml |
Updates the init snapshot to expect biome.json generation and its contents. |
src/registry/checks.rs |
Removes Prettier’s full_cmd so full-mode doesn’t run against {ROOT}. |
src/init/mod.rs |
Detects Biome selection and triggers Biome config generation; adds unit tests for the new generator. |
src/init/generation.rs |
Implements generate_biome_config() to write biome.json with explicit space indentation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3 tasks
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
6fec4a0 to
94dc658
Compare
## Summary - split init grouping from `--fast-only` behavior by introducing a separate run policy - mark `renovate-deps` as adaptive and only run it in `--fast-only` when the change set is relevant - add unit and e2e coverage for the renovate relevance gate, and ignore the local `.cache/` dir ## Testing - `mise exec -- cargo test -q` - `mise run lint:fix`
martincostello
approved these changes
Apr 23, 2026
Merged
zeitlinger
pushed a commit
that referenced
this pull request
Apr 23, 2026
### Added - group linter renovate updates ([#209](#209)) ### Fixed - expand baseline guards for config and flint changes ([#215](#215)) - remove stale exclude_paths init placeholder ([#211](#211)) - baseline lint coverage changes ([#214](#214)) - align biome init and formatter ownership ([#205](#205)) ### Other - *(deps)* update dependency npm:renovate to v43.133.0 ([#216](#216)) - *(deps)* update dependency npm:renovate to v43.132.2 ([#212](#212)) - *(deps)* update taiki-e/install-action digest to 5f57d6c ([#204](#204)) - clarify that flint init works with existing mise.toml ([#208](#208)) - guard against overlapping fixer ownership ([#206](#206)) > [!IMPORTANT] > Close and reopen this PR to trigger CI checks. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
zeitlinger
added a commit
to grafana/otel-checker
that referenced
this pull request
Apr 27, 2026
Blocked by grafana/flint#205 ## Summary - Replaces super-linter Docker-based linting with the [flint](https://github.com/grafana/flint) binary - Adds native linting tools to `mise.toml`: shellcheck, shfmt, actionlint, editorconfig-checker, prettier, markdownlint-cli2, codespell (+ gofmt via existing `go` tool) - Removes `lint:super-linter`, `lint:links`, `lint:renovate-deps` bash tasks; replaces with `flint run` - Adds `.github/config/flint.toml` (exclude patterns, renovate-deps config) - Adds `.markdownlint.jsonc` with MD013 disabled ## Test plan - [ ] CI passes (flint run + golangci-lint) - [ ] `mise run lint` runs clean locally - [ ] `mise run lint:fix` auto-fixes issues --------- Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
biome.jsonwith explicit space indentation duringflint initbiome.jsoncformatter ownership conflictTesting