feat(release): migrate from release-please to release-plz#171
Merged
zeitlinger merged 10 commits intomainfrom Apr 16, 2026
Merged
feat(release): migrate from release-please to release-plz#171zeitlinger merged 10 commits intomainfrom
zeitlinger merged 10 commits intomainfrom
Conversation
- Replace release-please with release-plz for automated release PR and tag/release creation - Configure git_release_draft=true so releases are created as drafts, enabling binary upload before publishing - Replace taiki-e/upload-rust-binary-action with explicit build steps (mise for Rust setup, cross for aarch64, manual archive + sha256) - Upload assets to the draft release via the GitHub list API instead of the tag API (which returns 404 for drafts) - Add publish job that marks the release as non-draft after all builds succeed, satisfying the repo's immutable releases rule Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
This comment has been minimized.
This comment has been minimized.
- Add mise_version alongside mise_sha256 in each matrix entry so Renovate can update both together (matches test.yml convention) - Add PR footer asking to close and reopen to trigger CI checks (replaces the release-please pull-request-footer) Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
…limit Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the repository’s automated release process from release-please to release-plz, restructuring the GitHub Actions release workflow to support draft releases so binaries can be uploaded before publishing (aligning with the “immutable releases” constraint and #168).
Changes:
- Add
release-plz.tomlconfiguration (includinggit_release_draft = true) and a newrelease-plzGitHub Actions workflow. - Replace the release workflow’s binary upload action with explicit build/archive/checksum steps and a draft-release asset upload via the Releases list API.
- Remove release-please workflow and its configuration/manifest files.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
release-plz.toml |
Adds release-plz workspace configuration and PR body template. |
.github/workflows/release.yml |
Reworks release build/upload/publish flow for draft releases + manual asset upload. |
.github/workflows/release-plz.yml |
Introduces release-plz automation on pushes to main (release PR + release). |
.github/workflows/release-please.yml |
Removes release-please automation workflow. |
.github/config/release-please-config.json |
Removes release-please configuration. |
.github/config/.release-please-manifest.json |
Removes release-please manifest/version tracking. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
This comment has been minimized.
This comment has been minimized.
- Add zizmor ignore annotation for cache-poisoning (tag-triggered workflow, sha256 verified, not susceptible to fork PR cache poisoning) - Use shasum -a 256 on macOS (sha256sum not available without coreutils) - Use --paginate when listing releases to handle repos with many releases; fail fast if tag not found - Delete pre-existing release assets before upload to support re-runs Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
- Rename "Archive (Unix)" → "Archive (non-Windows)" to match condition
- Replace ${{ github.repository }} with ${GITHUB_REPOSITORY} in run: steps to avoid expression injection
- Simplify release-plz.toml pr_body: drop Jinja2 template, use {{ changelog }} + CI trigger note
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
martincostello
approved these changes
Apr 16, 2026
Merged
zeitlinger
added a commit
that referenced
this pull request
Apr 16, 2026
### Added - *(release)* migrate from release-please to release-plz ([#171](#171)) ### Fixed - *(release)* use correct template variable in pr_body ([#178](#178)) - *(release)* suppress component prefix in release-please tags ([#166](#166)) - *(release)* add workflow_dispatch to retrigger for existing tags ([#167](#167)) ### Other - move icon to assets/ to fix release-plz ([#177](#177)) - *(deps)* update dependency npm:renovate to v43.102.11 [security] ([#174](#174)) - *(deps)* update rust crate similar to v3.1.0 ([#173](#173)) - *(deps)* update dependency github:mvdan/sh to v3.13.1 ([#163](#163)) > [!IMPORTANT] > Close and reopen this PR to trigger CI checks. --------- Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
This was referenced Apr 16, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git_release_draft = trueso GitHub releases are created as drafts, enabling binary upload before publishing (resolves Re-enable immutable releases once binary upload workflow is proven #168)taiki-e/upload-rust-binary-actionwith explicit build steps: mise for Rust setup, cross for aarch64, manual archive + sha256GET /releases/tags/{tag}publishjob that marks the release non-draft after all builds succeed — satisfies the repo's immutable releases ruleTest plan