-
Notifications
You must be signed in to change notification settings - Fork 1
feat(release): migrate from release-please to release-plz #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
392b21e
feat(release): migrate from release-please to release-plz
zeitlinger acb8988
fix(release): quote $GITHUB_ENV to satisfy shellcheck SC2086
zeitlinger 7c2b10b
fix(release): add mise_version to matrix, add PR footer
zeitlinger f74bd7e
fix(release): simplify pr_body template to stay within 100-char line …
zeitlinger ce3e258
fix(release): track mise version in renovate-tracked-deps
zeitlinger b0c2cf9
fix(renovate): extend mise matrix pattern to all workflow files
zeitlinger 36ec393
fix(release): address CI failures and Copilot review comments
zeitlinger 0badd3c
fix(release): disable mise cache instead of suppressing zizmor finding
zeitlinger 22aacab
fix(release): address review comments on release-plz migration
zeitlinger 2722a18
docs(release): add comments explaining release and release-pr jobs
zeitlinger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| --- | ||
| name: Release-plz | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
|
|
||
| permissions: {} | ||
|
|
||
| jobs: | ||
| release: | ||
| # Runs on every push to main. If the release PR was just merged (i.e. Cargo.toml | ||
| # version was bumped), creates a git tag and a draft GitHub release. The release.yml | ||
| # workflow then picks up the tag, builds binaries, and publishes the release. | ||
| name: Release | ||
| runs-on: ubuntu-24.04 | ||
| if: ${{ github.repository == 'grafana/flint' }} | ||
| permissions: | ||
| contents: write | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| fetch-depth: 0 | ||
| persist-credentials: false | ||
| - uses: release-plz/action@1528104d2ca23787631a1c1f022abb64b34c1e11 # v0.5 | ||
| with: | ||
| command: release | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| release-pr: | ||
| # Runs on every push to main. Keeps an open PR that bumps Cargo.toml version | ||
| # and updates CHANGELOG.md based on conventional commits since the last release. | ||
| # Merging this PR triggers the release job above. | ||
| name: Release PR | ||
| runs-on: ubuntu-24.04 | ||
| if: ${{ github.repository == 'grafana/flint' }} | ||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
| concurrency: | ||
| group: release-plz-pr-${{ github.ref }} | ||
| cancel-in-progress: false | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| fetch-depth: 0 | ||
| persist-credentials: false | ||
| - uses: release-plz/action@1528104d2ca23787631a1c1f022abb64b34c1e11 # v0.5 | ||
| with: | ||
| command: release-pr | ||
|
martincostello marked this conversation as resolved.
|
||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| [workspace] | ||
| git_release_draft = true | ||
| pr_body = """ | ||
| {{ changelog }} | ||
|
|
||
| > [!IMPORTANT] | ||
| > Close and reopen this PR to trigger CI checks. | ||
| """ |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.