feat: add preview MultipartUploadClient#listMultipartUploads #3396
Conversation
product-auto-label
bot
added
size: xl
Dhriti07
force-pushed
the
list-multipart-upload
branch
from
9de7d8a to
f6b31d3
Compare
Dhriti07
changed the title
| * | ||
| * @param request The request object containing the details for listing the multipart uploads. | ||
| * @return A {@link ListMultipartUploadsResponse} object containing the list of multipart uploads. | ||
| * @since 2.60.0 This new api is in preview and is subject to breaking changes. |
…v3.54.1 (#3381) Co-authored-by: BenWhitehead <[email protected]>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: cloud-java-bot <[email protected]>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
…3395) Co-authored-by: Dhriti Chopra <[email protected]>
|
|
||
| private final String eTag; | ||
| private final String md5; | ||
| private final String crc32c; |
There was a problem hiding this comment.
merge main here so that these changes are removed.
There was a problem hiding this comment.
Looks like they are part of this PR only, please move to a seprate PR with appropriate commit message and test cases.
...ud-storage/src/main/java/com/google/cloud/storage/multipartupload/model/MultipartUpload.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/cloud/storage/multipartupload/model/ListMultipartUploadsRequest.java
Show resolved
Hide resolved
...c/main/java/com/google/cloud/storage/multipartupload/model/ListMultipartUploadsResponse.java
Show resolved
Hide resolved
...ud-storage/src/main/java/com/google/cloud/storage/multipartupload/model/MultipartUpload.java
Outdated
Show resolved
Hide resolved
| import java.util.stream.Collectors; | ||
|
|
||
| /** A utility class to parse {@link HttpResponse} and create a {@link UploadPartResponse}. */ | ||
| /** A utility class to parse checksums from an {@link HttpResponse}. */ |
There was a problem hiding this comment.
Is this needed for listing the in progress uploads? If not, can this fix be moved to it's own PR?
There was a problem hiding this comment.
When moved to it's own PR, please also add tests covering the logic change in https://github.com/googleapis/java-storage/blob/main/google-cloud-storage/src/test/java/com/google/cloud/storage/ChecksumResponseParserTest.java
There was a problem hiding this comment.
Done, Those changes are moved to another PR and reverted from this PR.
Dhriti07
force-pushed
the
list-multipart-upload
branch
from
94a7989 to
bda8df6
Compare
Dhriti07
force-pushed
the
list-multipart-upload
branch
from
bda8df6 to
310754d
Compare
This reverts commit 21fb8fe.
...c/main/java/com/google/cloud/storage/multipartupload/model/ListMultipartUploadsResponse.java
Outdated
Show resolved
Hide resolved
| public ListMultipartUploadsResponse listMultipartUploads(ListMultipartUploadsRequest request) { | ||
| throw new UnsupportedOperationException("This operation is not yet implemented."); | ||
| } |
There was a problem hiding this comment.
We are okay breaking this classes API, it's annotated @InternalExtensionOnly, and the constructor is package private preventing subclasses by anything outside our package.
To get clirr to not fail for this we should add an ignore rule to https://github.com/googleapis/java-storage/blob/main/google-cloud-storage/clirr-ignored-differences.xml
<!-- MultipartUploadClient is @InternalExtensionOnly -->
<difference>
<!-- allow new method to be added at any time -->
<differenceType>7013</differenceType>
<className>com/google/cloud/storage/MultipartUploadClient</className>
<method>* *(*)</method>
</difference>And keep this method abstract
| public ListMultipartUploadsResponse listMultipartUploads(ListMultipartUploadsRequest request) { | |
| throw new UnsupportedOperationException("This operation is not yet implemented."); | |
| } | |
| public abstract ListMultipartUploadsResponse listMultipartUploads( | |
| ListMultipartUploadsRequest request); |
| private static String formatName(String name) { | ||
| // Only lowercase letters, digits, and "-" are allowed | ||
| return name.toLowerCase().replaceAll("[^\\w\\d\\-]", "-"); | ||
| return name.toLowerCase().replaceAll("[^\\w-]", "-"); |
There was a problem hiding this comment.
Why did we need to remove \d from this group?
There was a problem hiding this comment.
Also, the comment wasn't updated when the regex was and is now inaccurate.
5 participants
Adding model classes for ListMultipartUpload request and response.
Implementing ListMultipartUpload API.