feat: add UploadPartRequest.crc32c property and requisite plumbing #3395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
Dhriti07
changed the title
Dhriti07
force-pushed
the
custom-checksum
branch
from
10c3ce2 to
4359491
Compare
BenWhitehead
changed the title
BenWhitehead
requested changes
Nov 11, 2025
...-storage/src/main/java/com/google/cloud/storage/multipartupload/model/UploadPartRequest.java
Outdated
Show resolved
Hide resolved
...-storage/src/main/java/com/google/cloud/storage/multipartupload/model/UploadPartRequest.java
Outdated
Show resolved
Hide resolved
...-cloud-storage/src/main/java/com/google/cloud/storage/MultipartUploadHttpRequestManager.java
Show resolved
Hide resolved
...-storage/src/test/java/com/google/cloud/storage/ITMultipartUploadHttpRequestManagerTest.java
Show resolved
Hide resolved
Collaborator
|
I've rephrased the title of this PR to be more clear about what the feature is, as the title will appear as-is in the changelog/release notes. |
BenWhitehead
approved these changes
Nov 12, 2025
| } | ||
|
|
||
| /** | ||
| * Returns the CRC32C checksum of the part to upload. |
Contributor
There was a problem hiding this comment.
Can you add the encoding related information. It should be clear to the user what encoding it needs to do on the crc32c value.
| } | ||
| } | ||
|
|
||
| private void addChecksumHeader(@Nullable String crc32c, HttpHeaders headers) { |
Contributor
There was a problem hiding this comment.
crc32c won't be null given the 2 flows calling it are sending non-null value. @nullable is not required.
| } | ||
|
|
||
| private void addChecksumHeader(@Nullable String crc32c, HttpHeaders headers) { | ||
| if (crc32c != null) { |
Contributor
There was a problem hiding this comment.
this check is also redundant
Dhriti07
added a commit
that referenced
this pull request
Nov 13, 2025
…3395) Co-authored-by: Dhriti Chopra <[email protected]>
| * @since 2.61.0 This new api is in preview and is subject to breaking changes. | ||
| */ | ||
| @BetaApi | ||
| public Builder crc32c(@Nullable String crc32c) { |
Contributor
There was a problem hiding this comment.
Similar setup is required in the completeMultipartUpload as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding ability to provide custom crc32c for the Upload Request for MPU.
Refer: 3348