fix: using MoreObjects helper

Author: Dhriti Chopra

google-cloud-storage/src/main/java/com/google/cloud/storage/MultipartUploadHttpRequestManager.java

@@ -142,7 +142,6 @@ ListMultipartUploadsResponse sendListMultipartUploadsRequest(
                 + "{bucket}?uploads{&delimiter,encoding-type,key-marker,max-uploads,prefix,upload-id-marker}",
             params.build(),
             false);
-    System.out.println(listUri);
     HttpRequest httpRequest = requestFactory.buildGetRequest(new GenericUrl(listUri));
     httpRequest.getHeaders().putAll(headerProvider.getHeaders());
     httpRequest.setParser(objectParser);

google-cloud-storage/src/main/java/com/google/cloud/storage/multipartupload/model/ListMultipartUploadsRequest.java

@@ -17,6 +17,7 @@
 package com.google.cloud.storage.multipartupload.model;
 
 import com.google.api.core.BetaApi;
+import com.google.common.base.MoreObjects;
 import java.util.Objects;
 
 /**
@@ -159,16 +160,15 @@ public int hashCode() {
 
   @Override
   public String toString() {
-    StringBuilder sb = new StringBuilder("ListMultipartUploadsRequest{");
-    sb.append("bucket='").append(bucket).append("'");
-    sb.append(", delimiter='").append(delimiter).append("'");
-    sb.append(", encodingType='").append(encodingType).append(",");
-    sb.append(", keyMarker='").append(keyMarker).append(",");
-    sb.append(", maxUploads=").append(maxUploads);
-    sb.append(", prefix='").append(prefix).append(",");
-    sb.append(", uploadIdMarker='").append(uploadIdMarker).append(",");
-    sb.append('}');
-    return sb.toString();
+    return MoreObjects.toStringHelper(this)
+        .add("bucket", bucket)
+        .add("delimiter", delimiter)
+        .add("encodingType", encodingType)
+        .add("keyMarker", keyMarker)
+        .add("maxUploads", maxUploads)
+        .add("prefix", prefix)
+        .add("uploadIdMarker", uploadIdMarker)
+        .toString();
   }
 
   /**

google-cloud-storage/src/main/java/com/google/cloud/storage/multipartupload/model/ListMultipartUploadsResponse.java

@@ -20,6 +20,7 @@
 import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlElementWrapper;
 import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlProperty;
 import com.google.api.core.BetaApi;
+import com.google.common.base.MoreObjects;
 import com.google.common.collect.ImmutableList;
 import java.util.ArrayList;
 import java.util.List;
@@ -288,40 +289,20 @@ public int hashCode() {
 
   @Override
   public String toString() {
-    return "ListMultipartUploadsResponse{"
-        + "uploads="
-        + getUploads()
-        + ", bucket='"
-        + bucket
-        + "'"
-        + ", delimiter='"
-        + delimiter
-        + "'"
-        + ", encodingType='"
-        + encodingType
-        + "'"
-        + ", keyMarker='"
-        + keyMarker
-        + "'"
-        + ", uploadIdMarker='"
-        + uploadIdMarker
-        + "'"
-        + ", nextKeyMarker='"
-        + nextKeyMarker
-        + "'"
-        + ", nextUploadIdMarker='"
-        + nextUploadIdMarker
-        + "'"
-        + ", maxUploads="
-        + maxUploads
-        + ", prefix='"
-        + prefix
-        + "'"
-        + ", isTruncated="
-        + isTruncated
-        + ", commonPrefixes="
-        + getCommonPrefixes()
-        + '}';
+    return MoreObjects.toStringHelper(this)
+        .add("uploads", getUploads())
+        .add("bucket", bucket)
+        .add("delimiter", delimiter)
+        .add("encodingType", encodingType)
+        .add("keyMarker", keyMarker)
+        .add("uploadIdMarker", uploadIdMarker)
+        .add("nextKeyMarker", nextKeyMarker)
+        .add("nextUploadIdMarker", nextUploadIdMarker)
+        .add("maxUploads", maxUploads)
+        .add("prefix", prefix)
+        .add("isTruncated", isTruncated)
+        .add("commonPrefixes", getCommonPrefixes())
+        .toString();
   }
 
   /**

google-cloud-storage/src/main/java/com/google/cloud/storage/multipartupload/model/MultipartUpload.java

@@ -19,6 +19,7 @@
 import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlProperty;
 import com.google.api.core.BetaApi;
 import com.google.cloud.storage.StorageClass;
+import com.google.common.base.MoreObjects;
 import java.time.OffsetDateTime;
 import java.util.Objects;
 
@@ -118,18 +119,11 @@ public int hashCode() {
 
   @Override
   public String toString() {
-    return new StringBuilder("MultipartUpload{")
-        .append("key='")
-        .append(key)
-        .append('\'')
-        .append(", uploadId='")
-        .append(uploadId)
-        .append('\'')
-        .append(", storageClass=")
-        .append(storageClass)
-        .append(", initiated=")
-        .append(initiated)
-        .append('}')
+    return MoreObjects.toStringHelper(this)
+        .add("key", key)
+        .add("uploadId", uploadId)
+        .add("storageClass", storageClass)
+        .add("initiated", initiated)
         .toString();
   }