Skip to content

sample: add license to the generated sample files#8

Merged
pongad merged 2 commits intogoogleapis:masterfrom
pongad:license
Sep 21, 2018
Merged

sample: add license to the generated sample files#8
pongad merged 2 commits intogoogleapis:masterfrom
pongad:license

Conversation

@pongad
Copy link
Copy Markdown
Contributor

@pongad pongad commented Sep 21, 2018

No description provided.

@yihanzhen
Copy link
Copy Markdown
Contributor

Does sample.want need to be updated?

@pongad
Copy link
Copy Markdown
Contributor Author

pongad commented Sep 21, 2018

I don't think so. sample.want only tests the body of the file, not the header.

Copy link
Copy Markdown
Contributor

@yihanzhen yihanzhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pongad pongad merged commit 8083ac4 into googleapis:master Sep 21, 2018
@pongad pongad deleted the license branch September 21, 2018 18:27
julieqiu added a commit to julieqiu/gapic-generator-go that referenced this pull request Oct 5, 2023
Vulnerability #1: GO-2023-1571
    Denial of service via crafted HTTP/2 stream in net/http and golang.org/x/net
  More info: https://pkg.go.dev/vuln/GO-2023-1571
  Module: golang.org/x/net
    Found in: golang.org/x/net@v0.0.0-20210405180319-a5a99cb37ef4
    Fixed in: golang.org/x/net@v0.7.0
    Example traces found:
      #1: internal/gengapic/options.go:172:21: gengapic.transport.String calls fmt.Sprintf, which eventually calls http2.ErrCode.String
      #2: internal/gengapic/options.go:172:21: gengapic.transport.String calls fmt.Sprintf, which eventually calls http2.FrameType.String
      #3: internal/gengapic/options.go:172:21: gengapic.transport.String calls fmt.Sprintf, which eventually calls http2.Setting.String
      #4: internal/gengapic/options.go:172:21: gengapic.transport.String calls fmt.Sprintf, which eventually calls http2.SettingID.String
      googleapis#5: internal/printer/printer.go:62:13: printer.P.Printf calls fmt.Fprintf, which eventually calls http2.chunkWriter.Write
      googleapis#6: internal/gengapic/options.go:172:21: gengapic.transport.String calls fmt.Sprintf, which eventually calls http2.duplicatePseudoHeaderError.Error
      googleapis#7: internal/gengapic/options.go:172:21: gengapic.transport.String calls fmt.Sprintf, which eventually calls http2.headerFieldNameError.Error
      googleapis#8: internal/gengapic/options.go:172:21: gengapic.transport.String calls fmt.Sprintf, which eventually calls http2.headerFieldValueError.Error
      googleapis#9: internal/gengapic/options.go:172:21: gengapic.transport.String calls fmt.Sprintf, which eventually calls http2.pseudoHeaderError.Error
      googleapis#10: internal/gengapic/options.go:172:21: gengapic.transport.String calls fmt.Sprintf, which eventually calls http2.writeData.String
@renovate-bot renovate-bot mentioned this pull request May 26, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants