properly read LRO type from proto annotation#10
Merged
pongad merged 4 commits intogoogleapis:masterfrom Sep 25, 2018
pongad:lro-name
Merged
properly read LRO type from proto annotation#10pongad merged 4 commits intogoogleapis:masterfrom pongad:lro-name
pongad merged 4 commits intogoogleapis:masterfrom
pongad:lro-name
Conversation
and proplery reset writer when testing!
jba
approved these changes
Sep 25, 2018
| } | ||
|
|
||
| // Protoc adds '.' in front of names to signify they are fully qualified. | ||
| // Do that here so we can look up. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
julieqiu
added a commit
to julieqiu/gapic-generator-go
that referenced
this pull request
Oct 5, 2023
Vulnerability #1: GO-2023-1571 Denial of service via crafted HTTP/2 stream in net/http and golang.org/x/net More info: https://pkg.go.dev/vuln/GO-2023-1571 Module: golang.org/x/net Found in: golang.org/x/net@v0.0.0-20210405180319-a5a99cb37ef4 Fixed in: golang.org/x/net@v0.7.0 Example traces found: #1: internal/gengapic/options.go:172:21: gengapic.transport.String calls fmt.Sprintf, which eventually calls http2.ErrCode.String #2: internal/gengapic/options.go:172:21: gengapic.transport.String calls fmt.Sprintf, which eventually calls http2.FrameType.String #3: internal/gengapic/options.go:172:21: gengapic.transport.String calls fmt.Sprintf, which eventually calls http2.Setting.String #4: internal/gengapic/options.go:172:21: gengapic.transport.String calls fmt.Sprintf, which eventually calls http2.SettingID.String googleapis#5: internal/printer/printer.go:62:13: printer.P.Printf calls fmt.Fprintf, which eventually calls http2.chunkWriter.Write googleapis#6: internal/gengapic/options.go:172:21: gengapic.transport.String calls fmt.Sprintf, which eventually calls http2.duplicatePseudoHeaderError.Error googleapis#7: internal/gengapic/options.go:172:21: gengapic.transport.String calls fmt.Sprintf, which eventually calls http2.headerFieldNameError.Error googleapis#8: internal/gengapic/options.go:172:21: gengapic.transport.String calls fmt.Sprintf, which eventually calls http2.headerFieldValueError.Error googleapis#9: internal/gengapic/options.go:172:21: gengapic.transport.String calls fmt.Sprintf, which eventually calls http2.pseudoHeaderError.Error googleapis#10: internal/gengapic/options.go:172:21: gengapic.transport.String calls fmt.Sprintf, which eventually calls http2.writeData.String
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and proplery reset writer when testing!