Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Olympus: stop docker push #675

Merged
merged 4 commits into from
Sep 19, 2018
Merged

Olympus: stop docker push #675

merged 4 commits into from
Sep 19, 2018

Conversation

marwan-at-work
Copy link
Contributor

Stops creating Olympus images when merging to master.
Updates #612

@marwan-at-work marwan-at-work requested a review from a team as a code owner September 19, 2018 05:05
@codecov-io
Copy link

codecov-io commented Sep 19, 2018 •
edited
Loading

Codecov Report

Merging #675 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #675   +/-   ##
=======================================
  Coverage   44.24%   44.24%           
=======================================
  Files         105      105           
  Lines        3232     3232           
=======================================
  Hits         1430     1430           
  Misses       1665     1665           
  Partials      137      137

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6910a5e...7fa878a. Read the comment docs.

michalpristas
michalpristas approved these changes Sep 19, 2018
View reviewed changes
Copy link
Member

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not removing it completely, we can go back in time with git

@marwan-at-work
Copy link
Contributor Author

@michalpristas will do!

@marwan-at-work marwan-at-work merged commit 86d94c3 into gomods:master Sep 19, 2018
@marwan-at-work marwan-at-work mentioned this pull request Sep 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalpristas michalpristas michalpristas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marwan-at-work @codecov-io @michalpristas