Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Park Olympus Until Designs Are Finalized #612

Closed
marwan-at-work opened this issue Aug 31, 2018 · 8 comments
Closed

Park Olympus Until Designs Are Finalized #612

marwan-at-work opened this issue Aug 31, 2018 · 8 comments
Labels
proposal A proposal for discussion and possibly a vote

Comments

@marwan-at-work
Copy link
Contributor

marwan-at-work commented Aug 31, 2018

I'm not sure what this issue would entail exactly, but the current Olympus directory is quite outdate and not being used at all. It also causes some builds to break when you do some refactoring for the Proxy.

Should we remove Olympus and rewrite it once the designs/paper is complete and ready for dev?

Or should we just update the CI/CD to ignore the olympus directory for now?

Or should we just leave things the way they are?

@ghost
Copy link

ghost commented Aug 31, 2018

I'm in favor of parking for now. It seems we are using only the proxy at the moment, and in the design doc from Brian there is question of whether we even need Olympus.

ref: https://docs.google.com/document/d/1F0cVKxX7kEzxjrr09moqFzRQ7FoNc-Z2igfsEIkp7mc/edit?usp=sharing

@marwan-at-work
Copy link
Contributor Author

cc @arschles

@komuw
Copy link
Member

komuw commented Sep 3, 2018

we could move olympus to a new repo underhttps://github.com/gomods until it's final fate is decided.

@marpio marpio added the proposal A proposal for discussion and possibly a vote label Sep 3, 2018
@ghost
Copy link

ghost commented Sep 3, 2018

@komuw this would just be not working on Olympus until we set the design. No need to move the code.

@komuw
Copy link
Member

komuw commented Sep 4, 2018

It also causes some builds to break when you do some refactoring for the Proxy.

if builds break because of code that you should not be maintaining(olympus), then you actually have to start maintaining that code.

@arschles
Copy link
Member

arschles commented Sep 4, 2018

I saw up above in the thread that we could omit it from the build, and I'm cool with that. what do folks think about also adding something to the cmd/olympus README?

@ghost
Copy link

ghost commented Sep 4, 2018

I like it, just skip in the build for now and leave a note until we are ready to move forward on it.

@arschles
Copy link
Member

As of #772, we're going to focus on the global proxy and not on the registry (which is what Olympus was). Since this issue was for parking Olympus until designs are finalized, that's obsolete now. I'm going to close this and open a new issue for removing Olympus code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal A proposal for discussion and possibly a vote
Projects
None yet
Development

No branches or pull requests

4 participants