The master build seems to be failing

[arschles]

Describe the bug

Travis CI builds for the master branch seem to be failing. Here is a recent failure: https://travis-ci.org/gomods/athens/builds/427422588?utm_source=email&utm_medium=notification

They aren't failing on PR builds, though.
Error Message

Error: file not found
       1: cmd/logger/logger.go:294:logger.LogIf()
       2: cmd/fs-v1.go:963:cmd.(*FSObjects).listDirFactory.func1()
       3: cmd/tree-walk.go:145:cmd.doTreeWalk()
       4: cmd/tree-walk.go:253:cmd.startTreeWalk.func1()

This log output is here

To Reproduce

Run tests on the master branch, or merge a PR so that a build against master kicks off

Expected behavior

I expected master branch builds to pass. They should pass on every build against master.

Environment (please complete the following information):

• OS: Travis CI linux (iirc this is an Ubuntu 16 64 bit distro)
• Go version : 1.11
• Buffalo Version : 0.12.4
• Olympus or proxy version : tip of master

Additional context

This looks like an issue specific to master because PR builds pass before we merge them, so I'm suspecting that we're seeing a problem with configuration that only pops up for master builds.

[manugupt1]

I had a look at the logs couple of days back, it seems like the vendored directory is not being properly written and some of the bugs are introduced here

Error: file not found
       1: cmd/logger/logger.go:294:logger.LogIf()
       2: cmd/fs-v1.go:963:cmd.(*FSObjects).listDirFactory.func1()
       3: cmd/tree-walk.go:145:cmd.doTreeWalk()
       4: cmd/tree-walk.go:253:cmd.startTreeWalk.func1()

and at the end you can find go.mod and go.sum has changed

This will be a good starting point for anyone looking into this issue.

I can't look at this issue, so anyone can claim this one.

[penDerGraft]

Noticed a couple of things looking at this locally.

1. The make setup-dev-env command modifies go.mod and go.sum, by adding golint and its indirect deps (assuming that's because of this line here? )
2. The builds started failing after the removal of the dep files here

Wondering if in the changeover somehow golint didn't get added to the .mod and .sum files. I think it's possible that just running make setup-dev-env locally and committing the modified go.mod and go.sum files will fix the build.

Side note that I still don't think this addresses the error above, but it doesn't look like that section of the build is actually failing. Everything seems green until it tries to deploy.

[marwan-at-work]

Fixed by
#679
#678
#676
#675
#674
#635