Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gerritbot: handle Draft Pull Requests in a sensible way #30244

Closed
dmitshur opened this issue Feb 15, 2019 · 4 comments
Closed

x/build/cmd/gerritbot: handle Draft Pull Requests in a sensible way #30244

dmitshur opened this issue Feb 15, 2019 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) Community FeatureRequest Issues asking for a new feature that does not need a proposal. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Feb 15, 2019 •
edited
Loading

GitHub has released a new feature today, Draft Pull Requests:

https://github.blog/2019-02-14-introducing-draft-pull-requests/

This is a tracking issue to make sure gerritbot handles such PRs, if people make them, in a way that makes sense.

We need to investigate and decide what needs to happen differently, if anything at all. It'll probably be easier to wait for draft PRs to be sent before starting the investigation. We can also tell how big of a deal it is then.

If we need to do anything, I suspect we want to set the Gerrit WIP bit to mirror the GitHub draft status. Or, if the intended use of draft PRs is to signal "DO NOT REVIEW" (rather than "DO NOT SUBMIT"), perhaps not importing into Gerrit until the draft status is removed is a good idea.

GitHub has added preview API support for both GitHub v3 and v4 APIs. The tracking issue for adding support for this to go-github is google/go-github#1120.

/cc @bradfitz @andybons
@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. FeatureRequest Issues asking for a new feature that does not need a proposal. Community labels Feb 15, 2019
@gopherbot gopherbot added this to the Unreleased milestone Feb 15, 2019
@dmitshur dmitshur changed the title x/build/cmd/gerritbot: handle Draft Pull Requests in a coherent way x/build/cmd/gerritbot: handle Draft Pull Requests in a sensible way Feb 15, 2019
@dmitshur dmitshur added WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Feb 27, 2019
@gopherbot
Copy link
Contributor

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@dmitshur
Copy link
Contributor Author

Giving this more time.

@dmitshur dmitshur reopened this Mar 27, 2019
@dmitshur dmitshur reopened this Mar 27, 2019
hickford added a commit to hickford/build that referenced this issue Nov 14, 2022
@hickford
Set Gerrit WIP when GitHub PR is draft.
a5a6d14 
Fixes golang/go#30244
@hickford hickford mentioned this issue Nov 14, 2022
Closed
hickford added a commit to hickford/build that referenced this issue Nov 14, 2022
@hickford
Set Gerrit WIP when GitHub PR is draft.
178cd3c 
Fixes golang/go#30244
@dmitshur dmitshur added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. labels Nov 14, 2022
hickford added a commit to hickford/build that referenced this issue Nov 15, 2022
@hickford
cmd/gopherbot: set Gerrit WIP when GitHub PR is draft
3362cff 
Fixes golang/go#30244
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/450315 mentions this issue: cmd/gopherbot: set Gerrit WIP when GitHub PR is draft

hickford added a commit to hickford/build that referenced this issue Nov 15, 2022
@hickford
cmd/gopherbot: set Gerrit WIP when GitHub PR is draft
512da49 
Fixes golang/go#30244
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Nov 15, 2022
@dmitshur dmitshur moved this to In Progress in Go Release Nov 15, 2022
Repository owner moved this from In Progress to Done in Go Release Nov 15, 2022
hickford added a commit to hickford/build that referenced this issue Nov 15, 2022
@hickford
cmd/gerritbot: make sure to update when draft status changes
565d01c 
Updates golang/go#30244

Change-Id: I29ce3bc51e0ef2ee8012c0ad2547ff2dd0c56912
@hickford hickford mentioned this issue Nov 15, 2022
Closed
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/451075 mentions this issue: cmd/gerritbot: make sure to update when draft status changes

gopherbot pushed a commit to golang/build that referenced this issue Nov 16, 2022
@hickford @gopherbot
cmd/gerritbot: make sure to update when draft status changes
2f9ee95 
Updates golang/go#30244

Change-Id: I670d4444ffbe29a079fb4a933e74c34c7c5de026
GitHub-Last-Rev: 565d01c
GitHub-Pull-Request: #48
Reviewed-on: https://go-review.googlesource.com/c/build/+/451075
Run-TryBot: Dmitri Shuralyov <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Matthew Hickford <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
@golang golang locked and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) Community FeatureRequest Issues asking for a new feature that does not need a proposal. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

Successfully merging a pull request may close this issue.

cmd/gerritbot: set Gerrit WIP when GitHub PR is draft hickford/build
2 participants
@dmitshur @gopherbot