Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/gerritbot: set Gerrit WIP when GitHub PR is draft #47

Closed
wants to merge 1 commit into from
Closed

cmd/gerritbot: set Gerrit WIP when GitHub PR is draft #47

wants to merge 1 commit into from

Conversation

hickford
Copy link
Contributor

@hickford hickford commented Nov 14, 2022 •
edited by dmitshur
Loading

When uploading a new patch set to Gerrit, set the Gerrit CL WIP bit
to be the same as the GitHub Pull Request draft bit.

Fixes golang/go#30244.

@gopherbot
Copy link
Contributor

This PR (HEAD: a5a6d14) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/build/+/450315 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@hickford hickford force-pushed the gerrit-wip branch 2 times, most recently from 178cd3c to a9716bd Compare November 14, 2022 17:24
@gopherbot
Copy link
Contributor

This PR (HEAD: a9716bd) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/build/+/450315 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 2: Run-TryBot+1

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450315.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450315.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450315.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 2: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450315.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 3362cff) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/build/+/450315 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@hickford hickford changed the title Set Gerrit WIP when GitHub PR is draft. cmd/gopherbot: set Gerrit WIP when GitHub PR is draft Nov 15, 2022
@gopherbot
Copy link
Contributor

Message from Matt Hickford:

Patch Set 5:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450315.
After addressing review feedback, remember to publish your drafts!

@dmitshur dmitshur changed the title cmd/gopherbot: set Gerrit WIP when GitHub PR is draft cmd/gerritbot: set Gerrit WIP when GitHub PR is draft Nov 15, 2022
@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 6: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/450315.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450315.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450315.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 6: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450315.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450315.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 512da49) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/build/+/450315 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Matt Hickford:

Patch Set 7:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450315.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 7: Run-TryBot+1 Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450315.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 7:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450315.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 7: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/450315.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450315.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 7: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450315.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Matt Hickford:

Patch Set 7: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/450315.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Matthew Hickford:

Patch Set 7: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/450315.
After addressing review feedback, remember to publish your drafts!

@dmitshur dmitshur marked this pull request as ready for review November 15, 2022 20:52
gopherbot pushed a commit that referenced this pull request Nov 15, 2022
@hickford @gopherbot
cmd/gerritbot: set Gerrit WIP when GitHub PR is draft
db5a468 
When uploading a new patch set to Gerrit, set the Gerrit CL WIP bit
to be the same as the GitHub Pull Request draft bit.

Fixes golang/go#30244.

Change-Id: I29ce3bc51e0ef2ee8012c0ad2547ff2dd0c56912
GitHub-Last-Rev: 512da49
GitHub-Pull-Request: #47
Reviewed-on: https://go-review.googlesource.com/c/build/+/450315
Reviewed-by: Matt Hickford <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
Reviewed-by: Matthew Hickford <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Run-TryBot: Dmitri Shuralyov <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/450315 has been merged.

@gopherbot gopherbot closed this Nov 15, 2022
@hickford hickford deleted the gerrit-wip branch November 15, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x/build/cmd/gerritbot: handle Draft Pull Requests in a sensible way
2 participants
@hickford @gopherbot