-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Draft Pull Requests API Public Beta #1120
Comments
Hi @dmitshur , I am really new to Go and this repo but I tried to take a shot on this. I am sorry if there's anything wrong. Hope this works. Looking forward to the review. |
@joshuabezaleel Thank you for doing that! You don't have to worry, we have code review exactly so that we can improve the PR and get it into a mergeable state. |
This change implements support for a preview of a new Draft Pull Requests API, announced at https://developer.github.com/changes/2019-02-14-draft-pull-requests/. • Add new media type constant. • Use that media type in "list pull requests" and "get pull request" endpoints. • Add Draft struct field to the PullRequest struct. The "create pull request" and "update pull request" endpoints don't set the new media type yet, but that can be dealt with in a future change. Fixes #1120.
This change implements support for a preview of a new Draft Pull Requests API, announced at https://developer.github.com/changes/2019-02-14-draft-pull-requests/. • Add new media type constant. • Use that media type in "list pull requests" and "get pull request" endpoints. • Add Draft struct field to the PullRequest struct. The "create pull request" and "update pull request" endpoints don't set the new media type yet, but that can be dealt with in a future change. Fixes google#1120.
GitHub Developer API announcement: https://developer.github.com/changes/2019-02-14-draft-pull-requests/.
It looks like we'll need the following for this issue:
application/vnd.github.shadow-cat-preview+json
) must be added togithub.go
,Draft
field must be added to thePullRequest
struct that is returned from list/get PR endpoints,and also toEdit: This doesn't need to be done; this isn't a part of the preview API at this time.NewPullRequest
struct used for creating a PR,theEdit: This doesn't need to be done; this isn't a part of the preview API at this time.PullRequestsService.Edit
needs to be updated to allow the newDraft
field to be passedThis would be a great PR for any new contributor to this repo or a new Go developer. All contributions are greatly appreciated!
Feel free to volunteer for any issue and the issue can be assigned to you so that others don't attempt to duplicate the work.
Please check out our CONTRIBUTING.md guide to get started.
Thank you!
The text was updated successfully, but these errors were encountered: