-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ResourceLoader: Report error if resource type unrecognized #97370
Conversation
Cherry-pick for 4.3 included in #96606. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aa296b5
to
7758ede
Compare
Co-authored-by: Summersay415 <[email protected]>
7758ede
to
fe21913
Compare
@Summersay415, I've integrated your changes and made further changes so error handling is clearer. |
@RandomShaper Have you tested this now with the latest version? |
Yes, works as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems straightforward
Thanks! |
Fixed version of the reverted #95508.
Not tested yet, but maybe a brave reviewer can confirm this is good now.Fixes #95490.