Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error when no ResourceFormatLoader found (reverted) #95508

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

Summersay415
Copy link
Contributor

Fixes #95490

@Summersay415 Summersay415 requested a review from a team as a code owner August 14, 2024 04:50
@akien-mga akien-mga added this to the 4.4 milestone Aug 14, 2024
@akien-mga akien-mga merged commit 6a829d5 into godotengine:master Aug 19, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@Summersay415 Summersay415 deleted the loaded-when-not branch August 20, 2024 01:42
@RandomShaper RandomShaper added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 5, 2024
@RandomShaper
Copy link
Member

Cherry-pick for 4.3 included in #96606.

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 5, 2024
@akien-mga akien-mga changed the title Return error when no ResourceFormatLoader found Return error when no ResourceFormatLoader found (reverted) Sep 19, 2024
@akien-mga
Copy link
Member

Reverting with #97180 to fix regression #97153, this is wrongly returned in cases where it shouldn't.

@RandomShaper The cherry-pick should also be removed from #96606.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants