Fix GridContainer minimum size when there's a hidden parent #93386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calculating minimum size, GridContainer only looks at children that are returned from `as_sortable_control()`. That defaults to only showing children visible in the tree, so if the grid has a hidden parent the minimum size becomes (0, 0). After this change only the child itself needs to be visible, making `GridContainer::get_minimum_size()` behave the same way as other controls. Fixes godotengine#91722.
KoBeWi
approved these changes
Jun 20, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calculating minimum size, GridContainer only looks at children that are returned from
as_sortable_control(). That defaults to only showing children visible in the tree, so if the grid has a hidden parent the minimum size becomes (0, 0).After this change only the child itself needs to be visible, making
GridContainer::get_minimum_size()behave the same way as other controls.Fixes #91722.