Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening a Color picker in the inspector places it outside the display border #91722

Closed
Chaosus opened this issue May 8, 2024 · 6 comments · Fixed by #91757 or #93386
Closed

Opening a Color picker in the inspector places it outside the display border #91722

Chaosus opened this issue May 8, 2024 · 6 comments · Fixed by #91757 or #93386
Labels
bug regression topic:editor topic:gui
Milestone
4.3

Comments

@Chaosus
Copy link
Member

Chaosus commented May 8, 2024 •
edited
Loading

Tested versions

4.3 dev, 2042420

System information

Windows 11

Issue description

Opening a color picker dialog for the full-screened inspector (in the standard editor layout) place it outside the window, which makes it unusable:

изображение

Probably a recent regression (does not present in 4.3 dev 6)

Steps to reproduce

^^

Minimal reproduction project (MRP)

No need
@Chaosus Chaosus changed the title Opening a Color picker in the inspector places it outside the main window Opening a Color picker in the inspector places it outside the display border May 8, 2024
@Chaosus Chaosus added this to the 4.3 milestone May 8, 2024
@Chaosus
Copy link
Member Author

Chaosus commented May 9, 2024

Bisected to 5c28814, cc @KoBeWi

@Chaosus Chaosus mentioned this issue May 9, 2024
Merged
@jsjtxietian
Copy link
Contributor

jsjtxietian commented May 10, 2024 •
edited
Loading

Maybe it also affects the ColorPicker's preset buton, it's size is calculated as (int(get_minimum_size().width) - (preset_container->get_h_separation() * (PRESET_COLUMN_COUNT - 1))) / PRESET_COLUMN_COUNT, and I got -5 at the current master.

@KoBeWi
Copy link
Member

KoBeWi commented May 16, 2024 •
edited
Loading

A variation of this issue still exists.
image
Low ColorPickers appear below task bar. I don't know what is the cause this time.

@KoBeWi KoBeWi reopened this May 16, 2024
@akien-mga
Copy link
Member

Was this fixed by #92664?

@KoBeWi
Copy link
Member

KoBeWi commented Jun 18, 2024

No.

@anniryynanen
Copy link
Contributor

I'm going to put some time into trying to fix this.

@anniryynanen anniryynanen mentioned this issue Jun 20, 2024
Merged
fire pushed a commit to V-Sekai/godot that referenced this issue Jul 2, 2024
@anniryynanen @fire
Fix GridContainer minimum size when there's a hidden parent
89fb920 
When calculating minimum size, GridContainer only looks at children that are
returned from `as_sortable_control()`. That defaults to only showing children
visible in the tree, so if the grid has a hidden parent the minimum size
becomes (0, 0).

After this change only the child itself needs to be visible, making
`GridContainer::get_minimum_size()` behave the same way as other controls.

Fixes godotengine#91722.
MewPurPur pushed a commit to MewPurPur/godot that referenced this issue Jul 11, 2024
@anniryynanen @MewPurPur
Fix GridContainer minimum size when there's a hidden parent
539bc70 
When calculating minimum size, GridContainer only looks at children that are
returned from `as_sortable_control()`. That defaults to only showing children
visible in the tree, so if the grid has a hidden parent the minimum size
becomes (0, 0).

After this change only the child itself needs to be visible, making
`GridContainer::get_minimum_size()` behave the same way as other controls.

Fixes godotengine#91722.
sorascode pushed a commit to sorascode/godot-soras-version that referenced this issue Jul 22, 2024
@anniryynanen @sorascode
Fix GridContainer minimum size when there's a hidden parent
d641956 
When calculating minimum size, GridContainer only looks at children that are
returned from `as_sortable_control()`. That defaults to only showing children
visible in the tree, so if the grid has a hidden parent the minimum size
becomes (0, 0).

After this change only the child itself needs to be visible, making
`GridContainer::get_minimum_size()` behave the same way as other controls.

Fixes godotengine#91722.
Luis-Wong pushed a commit to Luis-Wong/godot that referenced this issue Jul 26, 2024
@anniryynanen @Luis-Wong
Fix GridContainer minimum size when there's a hidden parent
48eab93 
When calculating minimum size, GridContainer only looks at children that are
returned from `as_sortable_control()`. That defaults to only showing children
visible in the tree, so if the grid has a hidden parent the minimum size
becomes (0, 0).

After this change only the child itself needs to be visible, making
`GridContainer::get_minimum_size()` behave the same way as other controls.

Fixes godotengine#91722.
2nafish117 pushed a commit to 2nafish117/godot that referenced this issue Aug 5, 2024
@anniryynanen @2nafish117
Fix GridContainer minimum size when there's a hidden parent
2c03780 
When calculating minimum size, GridContainer only looks at children that are
returned from `as_sortable_control()`. That defaults to only showing children
visible in the tree, so if the grid has a hidden parent the minimum size
becomes (0, 0).

After this change only the child itself needs to be visible, making
`GridContainer::get_minimum_size()` behave the same way as other controls.

Fixes godotengine#91722.
chryan pushed a commit to chryan/godot that referenced this issue Aug 6, 2024
@anniryynanen @chryan
Fix GridContainer minimum size when there's a hidden parent
17492a3 
When calculating minimum size, GridContainer only looks at children that are
returned from `as_sortable_control()`. That defaults to only showing children
visible in the tree, so if the grid has a hidden parent the minimum size
becomes (0, 0).

After this change only the child itself needs to be visible, making
`GridContainer::get_minimum_size()` behave the same way as other controls.

Fixes godotengine#91722.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug regression topic:editor topic:gui
Projects
4.x Release Blockers
Status: Not Critical
Milestone
4.3
5 participants
@KoBeWi @Chaosus @akien-mga @jsjtxietian @anniryynanen