Don't rescan filesystem when adding new directory #93372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hilderin
reviewed
Sep 13, 2024
Hilderin
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Tested locally and that works perfectly, nice job! The idea to implement each operation individually sounds a great idea.
The only suggestion I could make but it's maybe out of scope of this PR is that if could be great to expand the FileSystemDock and select the folder after it's creation.
KoBeWi
deleted the
instant_folders,_like_instant_noodles,_but_for_storing_files
branch
|
Thanks! |
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #50576
I decided to split #87917 into smaller parts and use a different approach. Instead of guessing new file tree and doing a shadow scan, I skip scanning completely and manually add entries to EditorFileSystem. Hopefully every case in #50576 can be fixed this way.