Speed up filesystem dock operations #87917
Draft
+259
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
force-pushed
the
instant_gratification
branch
from
68f0c24
to
9f7c7a7
Compare
|
Finished 😬 I didn't touch ItemList view, not sure if there is an easy way to handle it. Also if you do file operations on modified TreeItems before rescan finished they will take no effect. I don't feel like improving it anymore though. |
KoBeWi
force-pushed
the
instant_gratification
branch
from
9f7c7a7
to
54e3eb8
Compare
|
@AThousandShips Did you take a look at this PR? |
|
I did glance at it but will take a fresh look |
This comment was marked as resolved.
This comment was marked as resolved.
KoBeWi
force-pushed
the
instant_gratification
branch
from
54e3eb8
to
85d497f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50576
godot.windows.editor.dev.x86_64_JhN90GK3xC.mp4
Moving, duplicating, renaming and creating folders is now instant.
In fact it's just a trick - the Tree is updated instantly upon action, but the rescan still runs in the background. When it finishes, it causes Tree sync with the actual filesystem. There are still some bugs like files appearing in wrong place or wrong selections, so putting as draft.