Make CSG shape dirty after changing Snap #93242
Merged
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
31
commented
Jun 16, 2024
31
commented
- Fixes Changing CSG node Snap doesn't regenerate mesh #93240
smix8
approved these changes
Jun 16, 2024
|
So that's why I thought changing Snap didn't have any effect… Thanks for fixing this after so long 🙂 |
Calinou
reviewed
Jun 16, 2024
There was a problem hiding this comment.
Tested locally, it works as expected.
csg_snap.mp4
While we're at it, I'd change CSGShape3D's snap documentation to mention that only the top-level CSG node' Snap property is taken into account. Child nodes' value is ignored for snapping vertices of the final (combined) CSG shape.
Calinou
reviewed
Jun 16, 2024
Update doc to mention that Snap only takes effect at the top level. Co-authored-by: Hugo Locurcio <[email protected]>
31
force-pushed
the
dev/31/csg-snap-dirty
branch
from
f529b95
to
649c87b
Compare
fire
approved these changes
Jun 16, 2024
5 tasks
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.