Autocompletion: Add support for string name option in more places #93057
+99
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Jun 12, 2024
HolonProduction
force-pushed
the
not-enough-code-paths
branch
from
0fc1d1c
to
51f74af
Compare
akien-mga
approved these changes
Jun 19, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93034
#66481 missed some code paths for special cases of argument options which are handled by the autocompletion.
Those cases now also consistently add the quotes to the preview which is in line with how we handle the default argument options. 'What you see is what you get', makes sense in this place.
Also adds test for most of the special code paths. The autoload code path is hard to test right now, since adding autoloads changes the output of
Node.print_orphan_nodeswhich is used by some other unit tests. I will look into that separately.