Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force editor progress dialog size update. #92856

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Force editor progress dialog size update. #92856

merged 1 commit into from
Jun 11, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jun 7, 2024

Fixes #92828

@bruvzg bruvzg added this to the 4.x milestone Jun 7, 2024
@passivestar
Copy link
Contributor

Tested, it works

@adamscott
Copy link
Member

Is the Main::iteration() (2 loops) call prevents the loading from happening? I'm curious.

@bruvzg
Copy link
Member Author

bruvzg commented Jun 8, 2024 •
edited
Loading

Is the Main::iteration() (2 loops) call prevents the loading from happening? I'm curious.

Two loops do not fix it, some value might do (10 iterations seems to), but it's better to just update rect directly.

@bruvzg bruvzg marked this pull request as ready for review June 8, 2024 20:51
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jun 10, 2024
@akien-mga akien-mga merged commit a957038 into godotengine:master Jun 11, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamscott adamscott adamscott left review comments

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:gui
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Progress popup window height isn't updating properly
4 participants
@bruvzg @passivestar @adamscott @akien-mga