Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pitch and volume to audio in animations #92642

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

killzebug
Copy link
Contributor

Makes audio in animations use the pitch and volume properties of the AudioStreamPlayer they're played from.
Fixes: #91605

Copy link
Member

@TokageItLab TokageItLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct fix and the wrong way to go about it.

The problem is that the AudioStreamPlayer properties are being ignored in the playback within AudioStreamPolyphonic, so AudioStreamPolyphonic needs to be fixed, not AnimationMixer.

Then, since AudioTrack is played back by AudioStreamPolyphonic, we need to add a feature to AudioTrackKey to allow it to set volume and pitch for each of them individually. And Instead of passing AudioStreamPlayer properties, we need to pass them individually from the key.

Simply put, AudioStreamPlayer properties should be treated as properties of the master track, and AudioTrackKeys should have properties for individual streams; It may be divided into two PRs as "Fix AudioStreamPlayer doesn't affect pitch and volume property to AudioStreamPolyphonic (bugfix)" and "Add volume and pitch property to AudioTrack key (enhancement)".

@TokageItLab TokageItLab removed this from the 4.3 milestone Jun 1, 2024
@AThousandShips AThousandShips added this to the 4.x milestone Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AudioStreamPolyphonic ignores the AudioStreamPlayer pitch and volume properties
3 participants