[Core] Add LocalVector::has for convenience
#91621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
May 6, 2024
|
Will open a godot-cpp PR as well |
smix8
approved these changes
May 6, 2024
|
Couldn't find any in there but will add any I find and squash Edit: Found them, they used an unorthodox syntax |
AThousandShips
force-pushed
the
localvector_has
branch
from
1620dc9
to
86de59d
Compare
|
Thanks! |
|
Shouldn't this have |
|
It is missing from several short methods here, and should happen with any decent compiler, would be worth going over cases generally though here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not too many cases but useful for parity and clarity
Came across the discrepancy when working on:
findwithcontains/haswhere applicable #91619