Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect bounds check in RenderingDevice push constant #90620

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Fix incorrect bounds check in RenderingDevice push constant #90620

merged 1 commit into from
Apr 23, 2024

Conversation

thimenesup
Copy link
Contributor

It also prevented its purpose of using a smaller slice of the buffer.

@thimenesup thimenesup requested a review from a team as a code owner April 13, 2024 13:03
@AThousandShips AThousandShips added this to the 4.3 milestone Apr 13, 2024
@akien-mga akien-mga changed the title Fix incorrect bounds check in rendering device push constant Fix incorrect bounds check in RenderingDevice push constant Apr 13, 2024
clayjohn
clayjohn approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@akien-mga akien-mga merged commit a55ffba into godotengine:master Apr 23, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@thimenesup thimenesup deleted the fix_push_constant branch May 9, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomShaper RandomShaper RandomShaper approved these changes

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug topic:rendering
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@thimenesup @akien-mga @RandomShaper @clayjohn @AThousandShips