Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3d axes flickering in the negative direction when extremely zoomed out #90255

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

Jabberdrake
Copy link
Contributor

When zooming out in the 3d node editor view, the negative half of all 3d axes starts flickering upon moving the camera. To fix this, the logic surrounding 3d transform "scaled" and "translated" calls has been altered so as to account for negative distance values.

Fixes #89215.

@Jabberdrake Jabberdrake requested a review from a team as a code owner April 5, 2024 10:23
@akien-mga akien-mga added this to the 4.3 milestone Apr 5, 2024
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

When zooming out in the 3d node editor view, the negative half
of all 3d axes starts flickering upon moving the camera. To fix this,
the logic surrounding 3d transform "scaled" and "translated" calls has
been altered so as to account for negative distance values.

Fixes godotengine#89215.
@akien-mga
Copy link
Member

Rebased to fix a temporary CI issue.

@akien-mga akien-mga merged commit dfcf803 into godotengine:master Apr 9, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3D axes flicker in the distant negative direction
3 participants