-
-
Notifications
You must be signed in to change notification settings - Fork 20.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use META_UNDERLINE_ON_HOVER
in built-in class reference
#89049
Use META_UNDERLINE_ON_HOVER
in built-in class reference
#89049
Conversation
The effect looks nice to me. The link is already highlighted, but you can hover over it to make sure the text is clickable. We could add an editor setting
I agree. Could you do it please? |
I'm questioning how because I wouldn't want them to be the accent color as it has helped distinguish them from properties/methods more. I could also just make an underline exception for constants and flags? That sounds fine to me for now. Last time I completely retouched the way built-in docs are stylized I explored the idea of hue-shifting the accent color for different "things". I really liked it back then and I could experiment on it furthermore after this PR. |
0fc709b
to
61136ec
Compare
Updated the PR to make an exception for constants and enums for now. Improvements in styling will come in bulk at a later time and I'm looking forward to try them |
holy compression on these GIFs 😳 other than that looks good to me :) |
Alright have a small video then! |
61136ec
to
635c64c
Compare
635c64c
to
3a0d056
Compare
Rebased after the recent fun stuff. Would be nice to see this along with the other fruits of our labour. |
META_UNDERLINE_ON_HOVER
in built-in class reference
Thanks! |
Supersedes #64861
I am moved. Thank you #89024.
You can see that those constants are harder to notice but it's nothing that can't be adjusted...Please feel free to share opinions but this is the way to go now. It's consistent with the online docs, and it's just... almost objectively good, compared to #64861 ?
Note that this PR does not affect
[url]
tags at all for clarity.