-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to remove underline in Editor Docs #64861
Conversation
Adds "text_editor/help/show_meta_underline" Editor Setting, enabled by default. When disabled, all meta words will still change cursor shape on hover.
97e8537
to
eea25b7
Compare
Could we improve the underline styling to make it less of a problem with regards to readability (e.g. by increasing the spacing or reducing its opacity)? I'd prefer doing this over adding an editor setting (so the solution benefits everyone automatically). |
The underline is hardcoded to be drawn with An addition to this that may suit everyone, however, is having the underline display only when hovered on. It may(?) be possible to do this without touching the Rich Text Label code. This is pretty much standard behaviour across browsers and applications, already, too. |
I don't like when websites do this – it makes it hard to know what's a link and what's not without having to point at everything with the mouse. I much prefer having a visible underline at all times, even if it's faint. |
Unfortunately that sounds very much like a preference matter. Therefore it can still be argued whether or not this "underline" thing should still be an Editor Setting, or not. |
We discussed this in a PR meeting. This calls for digging a bit further to find the One True Style to rule them all. We should aim to harmonize the display in the editor help and in the online docs. Some examples of differences which impact this change:
|
Seems like this has been (partially?) addressed by #68159.
And this was changed in #68132. |
I want to note one complication of adding underlines on hover would be requiring custom logic for it, because RichTextLabel does not support it, kind of similarly to what the Script Editor does when holding CTRL. |
Superseded by #89049. |
Oh noes what a shame! |
The current Docs are certainly an improvement in style, but there's something that has always given me enough of a headache to instead look up the Docs online, and I can't help but feel like the problem I personally have is much more pronounced for users that have trouble reading in general (poor vision, dyslexia...).
This PR adds a new Editor Setting "
text_editor/help/show_meta_underline
". This is enabled by default.When disabled, it can definitely be said that the text becomes much cleaner to read. To further sell the deal, in this PR, meta words change cursor shape on hover, regardless of setting:
(In the future, this may actually be useful to show meaningful tooltips in the Editor Documentation, too)