Force non-numeric ValueTrack to use Discrete with Dominant #88661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
force-pushed
the
fix-dominant-conv
branch
from
b16d591
to
d5060e1
Compare
TokageItLab
force-pushed
the
fix-dominant-conv
branch
from
d5060e1
to
8423574
Compare
AThousandShips
changed the title
|
I confirm this fixes the eye-blinking regression I noticed in https://github.com/gdquest-demos/godot-4-3d-third-person-controller, where the animation to blink the eyes by swapping textures no longer worked. This was the bug: |
akien-mga
approved these changes
Feb 22, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CallbackModeDiscreteproperty toAnimationMixerto handle the case of blending Continuous and Discrete tracks #86629Non-numeric value track needs to convert it to Discrete even if the AnimationMixer uses ForceContinuous.
To solve this correctly would require an implementation of godotengine/godot-proposals#8085, but it is a bit more complicated. For now, this PR only restores the behavior that #86629 broke.