Fix incorrect mapping of initial action as clear region continue to clear. #87022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarioSamo
force-pushed
the
clear_region_continue_fix
branch
from
a2304d5
to
2338bfb
Compare
|
Small doc update for CI. |
DarioSamo
force-pushed
the
clear_region_continue_fix
branch
from
2338bfb
to
80eacf1
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the regression caused by #84976 on canvas renderer where the 2D lights and shadows demo showed broken behavior.
INITIAL_ACTION_CLEAR_REGION_CONTINUE implied a clear on the region defined by the draw list. This was incorrectly assigned to "LOAD" in the new initial action redesign, leading to the framebuffer not being cleared as intended.
Before (broken):
After:
No existing code uses INITIAL_ACTION_CLEAR_REGION_CONTINUE anymore, so if there's any other potential places that should be reviewed, it's whatever used the action before the PR was merged, which was limited to a very small amount of effects (notably, omni-lights in 3D used them but they're not broken, so their action mappings seem correct).