Add bindings for setting and getting emulation mouse from touch and touch from mouse in input #86076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ouch from mouse functions
akien-mga
reviewed
Dec 12, 2023
core/input/input.cpp
Outdated
Comment on lines
146
to
149
| ClassDB::bind_method(D_METHOD("set_emulate_mouse_from_touch", "p_emulate"), &Input::set_emulate_mouse_from_touch); | ||
| ClassDB::bind_method(D_METHOD("is_emulating_mouse_from_touch"), &Input::is_emulating_mouse_from_touch); | ||
| ClassDB::bind_method(D_METHOD("set_emulate_touch_from_mouse", "p_emulate"), &Input::set_emulate_touch_from_mouse); | ||
| ClassDB::bind_method(D_METHOD("is_emulating_touch_from_mouse"), &Input::is_emulating_touch_from_mouse); |
There was a problem hiding this comment.
Suggested change
| ClassDB::bind_method(D_METHOD("set_emulate_mouse_from_touch", "p_emulate"), &Input::set_emulate_mouse_from_touch); | |
| ClassDB::bind_method(D_METHOD("is_emulating_mouse_from_touch"), &Input::is_emulating_mouse_from_touch); | |
| ClassDB::bind_method(D_METHOD("set_emulate_touch_from_mouse", "p_emulate"), &Input::set_emulate_touch_from_mouse); | |
| ClassDB::bind_method(D_METHOD("is_emulating_touch_from_mouse"), &Input::is_emulating_touch_from_mouse); | |
| ClassDB::bind_method(D_METHOD("set_emulate_mouse_from_touch", "enable"), &Input::set_emulate_mouse_from_touch); | |
| ClassDB::bind_method(D_METHOD("is_emulating_mouse_from_touch"), &Input::is_emulating_mouse_from_touch); | |
| ClassDB::bind_method(D_METHOD("set_emulate_touch_from_mouse", "enable"), &Input::set_emulate_touch_from_mouse); | |
| ClassDB::bind_method(D_METHOD("is_emulating_touch_from_mouse"), &Input::is_emulating_touch_from_mouse); |
There was a problem hiding this comment.
Are this property name only visual or this is reference to function properties?
akien-mga
reviewed
Dec 12, 2023
…ouch from mouse functions modified: core/input/input.cpp modified: doc/classes/Input.xml
…ouch from mouse functions
…ouch from mouse functions
This provides information for the debug monitors
…ouch from mouse functions
…ouch from mouse functions
This provides information for the debug monitors
…ouch from mouse functions
…ouch from mouse functions
…ouch from mouse functions
|
Please use rebasing to update your branch instead of merge commits, you will need to squash your commits, see here |
|
I think i messed up something seriously, it will be easier to create new pr, sorry about that |
|
Make sure to open your new PR on a dedicated branch and make your changes there and not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to set emulation of this input events in runtime, for example enabling it in game menu on touchscreen only device to allow use Control based buttons