Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Dock is not cleared when deleting selected node #84530

Closed
KoBeWi opened this issue Nov 6, 2023 · 3 comments · Fixed by #85686
Closed

Node Dock is not cleared when deleting selected node #84530

KoBeWi opened this issue Nov 6, 2023 · 3 comments · Fixed by #85686

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Nov 6, 2023

Godot version

4.2 beta4

System information

Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 (NVIDIA; 30.0.15.1403) - Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 Threads)

Issue description

When you select a node, the Node dock's signals and groups will point to that node. When you unselect it, the dock is properly cleared. If you instead delete the node, the dock content will stay and you can still make changes, which will go into the void (there is no way to restore the node without undoing the changes). What's worse, if you make a new scene and do the same to root node, it will result in editor crash.

Related is that the inspector does not fully clear either. The node header stays, the content is empty:
image

Steps to reproduce

  1. Add node
  2. Select it
  3. Go to Node dock's Groups
  4. Press Delete to delete the node (tested with the "no confirm" action, IIRC Shift+Delete by default?)
  5. The node is removed, but dock stays
  6. Add groups

Minimal reproduction project

N/A

@ghost
Copy link

ghost commented Nov 6, 2023

I reproduced this in Macbook pro (2019) Ventura 13.3.1.

@AnidemDex
Copy link

Was this solved previously? I'm working on v4.0.3.stable.official [5222a99] and I can reproduce this:
Before pressing Shift+Del (or before pressing Del to confirm the deletion)
image

After deleting the node (any of the methods above)
image

@KoBeWi KoBeWi removed the regression label Nov 7, 2023
@dnoftsger
Copy link

I think I have an idea of how to fix this issue, I'll look into coming up with a solution in the next week or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants