OpenXR: Add support for retrieving play area #85163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
reviewed
Dec 3, 2023
| @@ -690,6 +690,47 @@ bool OpenXRInterface::set_play_area_mode(XRInterface::PlayAreaMode p_mode) { | |||
| return false; | |||
| } | |||
|
|
|||
| PackedVector3Array OpenXRInterface::get_play_area() const { | |||
There was a problem hiding this comment.
Should this be exposed to gdscript?
There was a problem hiding this comment.
It is through the XRInterface, it's a virtual method
BastiaanOlij
force-pushed
the
openxr_play_area
branch
from
0dc9e1c
to
36610a9
Compare
m4gr3d
approved these changes
Dec 7, 2023
AThousandShips
approved these changes
Dec 7, 2023
BastiaanOlij
force-pushed
the
openxr_play_area
branch
from
36610a9
to
69a41b3
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
get_play_areafeature onOpenXRInterface. This allows the user to retrieve the are within which they can safely move before encountering the guardian boundary.This re-introduces the
get_play_spacefeature in Godot 3s OpenXR support.Closes: #85049