Reimport file when .import changes #84974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KoBeWi , thanks for looking into this! I was unaware of your attempt, and created #85067 (for 3.x). The approaches are certainly different: here the fix is about the modification time of files. Mine is more potentially disruptive (modifies the format of the There's also the possibility that the fixes need to be different for each major version, due to different root causes. |
|
Rebased and still works. |
akien-mga
approved these changes
Jul 8, 2024
|
Thanks! |
This was referenced Jul 14, 2024
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Jul 24, 2024
This is disabling the logic added in godotengine#84974 which caused godotengine#94416. That issue still needs to be debugged further, but this works around the regression and should have minimal usability impact on Android.
Borges-IST-2003
pushed a commit
to Borges-IST-2003/godot
that referenced
this pull request
Jul 24, 2024
This is disabling the logic added in godotengine#84974 which caused godotengine#94416. That issue still needs to be debugged further, but this works around the regression and should have minimal usability impact on Android.
Luis-Wong
pushed a commit
to Luis-Wong/godot
that referenced
this pull request
Jul 26, 2024
This is disabling the logic added in godotengine#84974 which caused godotengine#94416. That issue still needs to be debugged further, but this works around the regression and should have minimal usability impact on Android.
RadiantUwU
pushed a commit
to RadiantUwU/godot
that referenced
this pull request
Jul 27, 2024
This is disabling the logic added in godotengine#84974 which caused godotengine#94416. That issue still needs to be debugged further, but this works around the regression and should have minimal usability impact on Android.
kii-chan-reloaded
pushed a commit
to kii-chan-reloaded/godot
that referenced
this pull request
Aug 3, 2024
This is disabling the logic added in godotengine#84974 which caused godotengine#94416. That issue still needs to be debugged further, but this works around the regression and should have minimal usability impact on Android.
2nafish117
pushed a commit
to 2nafish117/godot
that referenced
this pull request
Aug 5, 2024
This is disabling the logic added in godotengine#84974 which caused godotengine#94416. That issue still needs to be debugged further, but this works around the regression and should have minimal usability impact on Android.
chryan
pushed a commit
to chryan/godot
that referenced
this pull request
Aug 6, 2024
This is disabling the logic added in godotengine#84974 which caused godotengine#94416. That issue still needs to be debugged further, but this works around the regression and should have minimal usability impact on Android.
maidopi-usagi
pushed a commit
to maidopi-usagi/godot
that referenced
this pull request
Sep 11, 2024
This is disabling the logic added in godotengine#84974 which caused godotengine#94416. That issue still needs to be debugged further, but this works around the regression and should have minimal usability impact on Android.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60730
Editor was already detecting that
.importfile has changed, but_test_for_reimport()which triggers the actual reimport did not check that.Might need some testing.