Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert LOD selection implementation to a previous working version #82000

Closed
wants to merge 2 commits into from
Closed

Revert LOD selection implementation to a previous working version #82000

wants to merge 2 commits into from

Conversation

briansemrau
Copy link
Contributor

@briansemrau briansemrau commented Sep 20, 2023 •
edited
Loading

Fixes #81995

See issue description for reason for reverting

May also fix #78664
Relevant to #67479

@briansemrau briansemrau requested a review from a team as a code owner September 20, 2023 18:46
@Chaosus Chaosus added this to the 4.2 milestone Sep 20, 2023
@briansemrau

This comment was marked as resolved.

Sign in to view
@YuriSizov YuriSizov modified the milestones: 4.2, 4.x Sep 20, 2023
@Calinou Calinou added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Sep 20, 2023
@mrjustaguy
Copy link
Contributor

mrjustaguy commented Sep 20, 2023 •
edited
Loading

Resolves #78664 but not entirely #67479

@mrjustaguy mrjustaguy mentioned this pull request Sep 20, 2023
Closed
@fire
Copy link
Member

fire commented Sep 21, 2023

I am ok with this, but I want the rendering team to take a look.

@AThousandShips AThousandShips added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Nov 28, 2023
@AThousandShips AThousandShips modified the milestones: 4.x, 4.3 Nov 28, 2023
@clayjohn clayjohn mentioned this pull request May 23, 2024
Merged
@akien-mga
Copy link
Member

akien-mga commented May 29, 2024 •
edited
Loading

Superseded by #92287 and #92290.

@akien-mga akien-mga closed this May 29, 2024
@akien-mga akien-mga removed cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels May 29, 2024
@akien-mga akien-mga removed this from the 4.3 milestone May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@Calinou Calinou Awaiting requested review from Calinou

Assignees
No one assigned
Labels
archived bug regression topic:rendering topic:3d
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LOD selection implementation is wrong Directional Shadow Pancake Size breaks Automatic LOD
8 participants
@briansemrau @mrjustaguy @fire @akien-mga @AThousandShips @Calinou @Chaosus @YuriSizov