Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix overwriting of Spatial's local transform #78439

Merged

Conversation

akien-mga
Copy link
Member

Modifies when 'DIRTY_LOCAL' flag is set to prevent a transform applied using set_transform to be overwritten by previous calls to change the node's rotation, translation or scale.

Redo of #44803 on 3.x.
Fixes #43130.

Modifies when 'DIRTY_LOCAL' flag is set to prevent a transform applied
using `set_transform` to be overwritten by previous calls to change the
node's rotation, translation or scale.

Fixes godotengine#43130.
Copy link
Member

@lawnjelly lawnjelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not checked in practice, as I don't have working development PC till my new one comes, but I think this should be fine.

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too!

@akien-mga akien-mga merged commit cb6ec43 into godotengine:3.x Jun 19, 2023
@akien-mga akien-mga deleted the spatial-fix-overwriting-local-transform branch June 19, 2023 19:11
@akien-mga
Copy link
Member Author

Thanks @mrushyendra!

@akien-mga akien-mga changed the title Fix overwriting of Spatial's local transform [3.x] Fix overwriting of Spatial's local transform Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants