Fix overwriting of Node3D's local space transform #44803
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the
DIRTY_LOCAL
flag is set and a new transform is supplied usingset_transform
, the new transform may be overwritten the next time it is read, because the transform is reset using the Node3D's previous rotation and scale, even though the new transform should supersede those.This PR modifies when the
DIRTY_LOCAL
flag is set to prevent a transform applied usingset_transform
being overwritten by any previous calls that changed the node's rotation, translation or scale.Closes #43130