Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Backport video loop property and fix for initial black frame #77979

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

paddy-exe
Copy link
Contributor

Backport of #77856 and #77857 to Godot 3.x

Showcase:

Without looping:

OhneLoop.mp4

With looping:

MitLoop.mp4

@kinami-imai
Copy link
Contributor

Very cool! ✨

Keep in mind that #77857 is not merged yet!

@paddy-exe
Copy link
Contributor Author

Very cool! ✨

Keep in mind that #77857 is not merged yet!

Thanks! :) and yeah, no worries. My main concern was for letsgamedev (The developer of Spindle) to have this fix for their games since they regularly use VideoPlayer Nodes in 3.x and he mentioned this issue to me when I met him in person.

@YuriSizov YuriSizov added this to the 3.6 milestone Jun 9, 2023
@akien-mga akien-mga merged commit 3b3c5f4 into godotengine:3.x Jun 15, 2023
@akien-mga
Copy link
Member

Thanks!

@paddy-exe paddy-exe deleted the video-loop-fix branch June 22, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants