Add loop property to VideoStreamPlayer
#77857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 4, 2023
KoBeWi
reviewed
Jun 5, 2023
anvilfolk
reviewed
Jun 5, 2023
kinami-imai
force-pushed
the
add_loop_property_to_videostreamplayer
branch
from
c4ea2af
to
15719e2
Compare
|
Force pushing to make changes based on reviews by @anvilfolk and @KoBeWi. |
KoBeWi
approved these changes
Jun 5, 2023
YuriSizov
changed the title
loop property to VideoStreamPlayer
|
Thanks! |
kinami-imai
added a commit
to kinami-imai/godot-docs
that referenced
this pull request
Sep 28, 2023
Since godotengine/godot#77857 is merged and will be released in 4.2, it would be great to update the documentation.
kinami-imai
added a commit
to kinami-imai/godot-docs
that referenced
this pull request
Sep 29, 2023
Since godotengine/godot#77857 is merged and will be released in 4.2, it would be great to update the documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of a group of three PRs (#77856 #77857 #77858) that solve godotengine/godot-proposals#264.
Currently, the only way to get a VideoStreamPlayer to loop, is by connecting the
on_finishedsignal to theplay()function. This can be confusing for new users unfamiliar with signals and buries a feature that is commonly used behind a number of clicks. This PR creates a new toggle to enable looping on VideoStreamPlayer nodes. The effect is identical as connecting the signal, the change is only for making the UI more intuitive.