Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix GridContainer max row/column calculations not skipping hidden children #76833

Conversation

kleonc
Copy link
Member

@kleonc kleonc commented May 8, 2023

3.x version of #62835.

Fixes #76827.

@kleonc kleonc added bug topic:gui cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels May 8, 2023
@kleonc kleonc added this to the 3.6 milestone May 8, 2023
@kleonc kleonc requested a review from a team as a code owner May 8, 2023 11:01
@akien-mga akien-mga merged commit 627a290 into godotengine:3.x May 8, 2023
@akien-mga
Copy link
Member

Thanks!

@kleonc kleonc deleted the gridcontainer-max-row-column-calculations-fix branch May 8, 2023 13:09
@akien-mga
Copy link
Member

Cherry-picked for 3.5.3.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants