Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in GridContainer with hidden children #62835

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Fixed bug in GridContainer with hidden children #62835

merged 1 commit into from
Jul 14, 2022

Conversation

besh81
Copy link
Contributor

@besh81 besh81 commented Jul 8, 2022

Fix a bug that occour when there are hidden children in grid_container.
The visualization isn't correct due to a wrong calculation of max_col and max_row that mistakenly includes hidden children.

@besh81 besh81 requested a review from a team as a code owner July 8, 2022 11:08
@KoBeWi KoBeWi added this to the 4.0 milestone Jul 8, 2022
@KoBeWi
Copy link
Member

KoBeWi commented Jul 8, 2022

Can you provide some minimal project that reproduces the bug? (is there maybe issue open about it?)
Also you need to run clang-format.

@besh81
Copy link
Contributor Author

besh81 commented Jul 8, 2022

I didn't find any issue in the tracker.

Here a simple project that reproduce the bug:
bug_grid_container.zip

Screenshot:
Cattura

As you can see in the second grid_container there is an empty space at the bottom due to the hidden children that shouldn't be there.
The second grid_container should be exactly like the first.

@YuriSizov YuriSizov changed the title Fixed bug in grid_container with hidden children Fixed bug in GridContainer with hidden children Jul 8, 2022
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs squash.

@YuriSizov
Copy link
Contributor

@besh81 Please squash commits, so we can merge this approved fix 🙂
If you need help with squashing, you can refer to this guide from the Godot documentation (or any article about squashing in Git, really).

Fix a bug that occour when there are hidden children in grid_container.
The visualization isn't correct due to a wrong calculation of max_col and max_row that mistakenly includes hidden children.
@besh81
Copy link
Contributor Author

besh81 commented Jul 14, 2022

After several attempts I think I did my first "squash" correctly or I hope so 😄
Please let me know if ok

@akien-mga akien-mga merged commit 74ab3dc into godotengine:master Jul 14, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants