Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add agent pause mode to NavigationServer #75888

Merged
merged 1 commit into from
Jun 18, 2023

Conversation

smix8
Copy link
Contributor

@smix8 smix8 commented Apr 10, 2023

Adds agent pause mode to NavigationServer.

Fixes #78384.

Required so users that do not use NavigationAgent node but the NavigationServer directly can also pause agent processing.

Split from and builds on top of pr #73658.

@smix8 smix8 requested review from a team as code owners April 10, 2023 13:35
@YuriSizov YuriSizov added this to the 4.1 milestone Apr 10, 2023
@smix8 smix8 force-pushed the navigation_pause_mode_4.x branch 2 times, most recently from d122918 to bd3251a Compare May 12, 2023 13:35
@smix8 smix8 modified the milestones: 4.1, 4.x Jun 6, 2023
@smix8 smix8 added the bug label Jun 18, 2023
@smix8 smix8 force-pushed the navigation_pause_mode_4.x branch from bd3251a to 62e6768 Compare June 18, 2023 01:12
@smix8
Copy link
Contributor Author

smix8 commented Jun 18, 2023

Rebased pr and added pause mode for the newer obstacles as well.

@smix8 smix8 force-pushed the navigation_pause_mode_4.x branch from 62e6768 to 554c9d4 Compare June 18, 2023 01:18
@akien-mga akien-mga modified the milestones: 4.x, 4.1 Jun 18, 2023
@smix8
Copy link
Contributor Author

smix8 commented Jun 18, 2023

Seems to work now for the obstacle.

Need to change the internals to make the assignments less awkward but will to that in a different pr for all navobjects.

Adds agent pause mode to NavigationServer.
@smix8 smix8 force-pushed the navigation_pause_mode_4.x branch from 554c9d4 to ae9dd47 Compare June 18, 2023 12:53
@akien-mga akien-mga merged commit 829b865 into godotengine:master Jun 18, 2023
@akien-mga
Copy link
Member

Thanks!

@smix8 smix8 deleted the navigation_pause_mode_4.x branch June 19, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NavigationAgent stops working when unpausing and pausing in same frame
3 participants