GDScript: Add missing member type check when resolving extends
#75879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalexeev
force-pushed
the
gds-fix-extends-crash
branch
from
a34753c
to
9a3aedd
Compare
dalexeev
force-pushed
the
gds-fix-extends-crash
branch
from
9a3aedd
to
66279b9
Compare
vnen
approved these changes
Apr 10, 2023
dalexeev
commented
Apr 10, 2023
| @@ -506,6 +523,9 @@ Error GDScriptAnalyzer::resolve_class_inheritance(GDScriptParser::ClassNode *p_c | |||
| if (!id_type.is_set()) { | |||
| push_error(vformat(R"(Could not find nested type "%s".)", id->name), id); | |||
| return ERR_PARSE_ERROR; | |||
| } else if (id_type.kind != GDScriptParser::DataType::SCRIPT && id_type.kind != GDScriptParser::DataType::CLASS) { | |||
There was a problem hiding this comment.
I still have some doubts about this. We should probably check if the identifier is a class or a constant containing a script/class. Also, I am not happy with the variety of error messages:
- Constant "A" is not a preloaded script or class.
- Identifier "X" is not a preloaded script or class.
- Cannot get nested types for extension from non-GDScript type "RefCounted".
- Could not find nested type "Baz".
- Cannot use variable "A" in extends chain.
There was a problem hiding this comment.
Let's fix the crash for now, and iterate on this in a follow-up.
|
Thanks! |
|
Cherry-picked for 4.0.3. This one slightly depends on #74844, but seems like usages of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #75870.