Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poll LSP/DAP clients for connection status updates #75850

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Poll LSP/DAP clients for connection status updates #75850

merged 1 commit into from
Apr 11, 2023

Conversation

rsubtil
Copy link
Contributor

@rsubtil rsubtil commented Apr 9, 2023

Closes #75849

Since #59582, polls now have to be done explicitly before getting a connection's status.

@rsubtil rsubtil requested review from a team as code owners April 9, 2023 11:37
@YuriSizov YuriSizov added this to the 4.1 milestone Apr 10, 2023
@Faless Faless merged commit 4ab0b38 into godotengine:master Apr 11, 2023
@Faless
Copy link
Collaborator

Faless commented Apr 11, 2023

Thanks!

@rsubtil rsubtil deleted the bugfix-lsp_dap_connection_poll branch April 11, 2023 09:33
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Faless Faless Faless approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:network
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

LSP and DAP connections are not terminating
3 participants
@rsubtil @Faless @YuriSizov