[Net] Make TCP poll explicit, drop is_connected_to_host. #59582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer hacked into `get_status` and renamed to `poll`. The old `poll` (for *nix `poll`, win `select`) is now called `wait`.
The UDP method is now called `is_socket_connected` to limit confusion with the actual host connection status which doesn't make sense in UDP. The TCP method is completly dropped, use get_status instead. The only one left is the WebSocketPeer one, which should be fine as is for now.
mhilbrunner
approved these changes
Mar 30, 2022
|
Thanks! |
This was referenced Apr 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Make
StreamPeerTCP::_poll_connectionexplicit.No longer hacked into
get_statusand renamed topoll.The old
poll(for *nixpoll, winselect) is now calledwait.Drop
is_connected_to_hostfor TCP and UDP.The UDP method is now called
is_socket_connectedto limit confusion with the actual host connection status which doesn't make sense in UDP.The TCP method is completly dropped, just use
get_statusinstead.The only one left is the WebSocketPeer one, which should be fine as is for now.
Fixes #22605
Fixes #18323