Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Fix UI responsiveness to touch taps #75699

Merged
merged 2 commits into from
Apr 24, 2023
Merged

[3.x] Fix UI responsiveness to touch taps #75699

merged 2 commits into from
Apr 24, 2023

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Apr 5, 2023 •
edited
Loading

  • Make tab's close button responsive to touch taps
  • Make layer and mask properties responsive to touch taps

Fixes Close a Scene and Modify a Mask property issues in #73707

main version

@m4gr3d m4gr3d added bug platform:android topic:editor cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Apr 5, 2023
@m4gr3d m4gr3d added this to the 3.6 milestone Apr 5, 2023
@m4gr3d m4gr3d requested a review from a team as a code owner April 5, 2023 16:26
@m4gr3d m4gr3d changed the title Make tab's close button responsive to touch taps [3.x] Make tab's close button responsive to touch taps Apr 5, 2023
@m4gr3d m4gr3d mentioned this pull request Apr 5, 2023
Merged
@m4gr3d m4gr3d changed the title [3.x] Make tab's close button responsive to touch taps [3.x] Fix UI responsiveness to touch taps Apr 5, 2023
@YuriSizov YuriSizov added cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release and removed cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Apr 11, 2023
@m4gr3d m4gr3d requested a review from KoBeWi April 13, 2023 16:36
@m4gr3d m4gr3d force-pushed the fix_ux_controls_3x branch 2 times, most recently from d0b434a to d980730 Compare April 23, 2023 04:35
KoBeWi
KoBeWi approved these changes Apr 23, 2023
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine.
I didn't test if it works, but I assume you tested it :P

@m4gr3d
Copy link
Contributor Author

m4gr3d commented Apr 24, 2023

Code looks fine. I didn't test if it works, but I assume you tested it :P

Yep, and validated that the glitch you observed in the 4.x version was also addressed in this version.

@m4gr3d m4gr3d merged commit dc97a2e into godotengine:3.x Apr 24, 2023
@m4gr3d m4gr3d deleted the fix_ux_controls_3x branch April 24, 2023 01:26
@lawnjelly lawnjelly mentioned this pull request May 29, 2023
Closed
@m4gr3d m4gr3d removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug platform:android topic:editor
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.
3 participants
@m4gr3d @KoBeWi @YuriSizov