Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SVG Font] Keep a copy of UTF-8 XML source string during the whole SVG processing. #75675

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Apr 5, 2023

Sometimes ThorVG is accessing source string after the load call return, and UTF-8 string should stay valid until processing is done. Also, remove 4 unnecessary UTF-32 → UTF-8 conversions per rendered glyph.

Fixes #75490

@bruvzg bruvzg added this to the 4.x milestone Apr 5, 2023
@bruvzg bruvzg requested a review from a team as a code owner April 5, 2023 06:38
@akien-mga akien-mga modified the milestones: 4.x, 4.1 Apr 5, 2023
@akien-mga akien-mga merged commit 44d5394 into godotengine:master Apr 5, 2023
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the tvg_store_string branch April 6, 2023 06:03
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor crashes using the "Noto Color Emoji" font
3 participants