Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor crashes using the "Noto Color Emoji" font #75490

Closed
jeroenheijmans opened this issue Mar 30, 2023 · 2 comments · Fixed by #75675
Closed

Editor crashes using the "Noto Color Emoji" font #75490

jeroenheijmans opened this issue Mar 30, 2023 · 2 comments · Fixed by #75675
Assignees
Milestone

Comments

@jeroenheijmans
Copy link

jeroenheijmans commented Mar 30, 2023

Godot version

4.0.1.stable.official [cacf499]

System information

Windows 10, OpenGL API 3.3.0 NVIDIA 528.49

Issue description

The editor hard crashes when a specific sequence of actions is done on the Label Settings of a Label control. It seems that selecting only one specific font as a SystemFont the editor crashes. For me it happens with "NotoColorEmoji-Regular.ttf" (version 2.038;GOOG;noto-emoji:20220906:4b1c5bfb0d5b1f5c69aa321d5b6e70656ead1d30) installed in C:\Users\MYUSERNAME\AppData\Local\Microsoft\Windows\Fonts; it might be because only that one font file sits there as the only Noto font file installed system wide, but regardless the Godot Editor should probably not hard-crash when this happens?

Steps to reproduce

Edit: even easier steps

  1. Download https://fonts.google.com/noto/specimen/Noto+Color+Emoji/
  2. Create new project
  3. Drag the .ttf to the Godot window file root
  • Result: the font file name shortly appears in Godot's file explorer before it crashes

Original steps

  1. Create a new project
  2. Add a root Control scene
  3. Add a Label child
  4. Add "New Label Settings" and expand it
  5. Expand the "Font" section, click the "" in the dropdown, pick "New SystemFont"
  6. Click "SystemFont" to expand it
  7. Click "Font Names" value "PackedStringArray (size 0)" to expand it
  8. Pick "+ Add Element" and choose "Courier New"
  9. Pick "+ Add Element" and choose "Noto Color Emoji"
  10. Click the trash icon next to "Courier New" to delete it
  • Result: editor window immediately crashes and closes down

  • Expected: array of font names to go back to 1, or a warning that my operation is not allowed

  • Variant steps: at step 8 (when no fonts are picked yet at all), add "Noto Color Emoji" as the first one

Minimal reproduction project

See steps to reproduce, it happens when starting clean as well.

Hope this helps! Let me know if I can add more details.

@bruvzg bruvzg self-assigned this Mar 30, 2023
@jeroenheijmans jeroenheijmans changed the title Editor crash when SystemFont on Label is only "Noto Color Emoji" Editor crashes using the "Noto Color Emoji" font Mar 30, 2023
@jeroenheijmans
Copy link
Author

Added a simplified set of steps and updated the title accordingly.

@Calinou
Copy link
Member

Calinou commented Mar 30, 2023

cc @bruvzg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants